Bring a large pot of salted water to a boil. Add the macaroni and cook it longer than usual — about 2–3 minutes past al dente — until very soft (Hawaiian-style mac salad uses softer pasta). Drain well and, while still warm, place the pasta in a large bowl.
While the pasta is still hot, sprinkle the vinegar over it and toss to coat. Let it sit for about 10 minutes to absorb.
In a separate bowl, whisk together the mayonnaise, milk, brown sugar, salt, and black pepper until smooth.
Add the shredded carrot, grated onion, and optional celery and green onions to the macaroni. Pour the dressing over everything and mix gently but thoroughly.
Cover and refrigerate for at least 2 hours (preferably overnight) to let the flavors meld. Stir before serving — if it looks a bit dry, you can mix in a splash more milk or mayo to loosen it up.